Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (cherry-pick): incorrect method name parsed from transaction data (#27363) #27379

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix (cherry-pick): incorrect method name parsed from transaction data (#27363) #27379

merged 1 commit into from
Sep 25, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Sep 24, 2024 •
edited by github-actions bot
Loading

Description

Cherry pick of #27363 for version 12.3.0.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0
Do not query 4byte if less than four bytes
816afb5 
Skip data render if 0x.
Ignore cached data if less than four bytes.
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Sep 24, 2024
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners September 24, 2024 20:28
@matthewwalsh0 matthewwalsh0 changed the title fix (cherry-pick): incorrect method name parsed from transaction #27363 fix (cherry-pick): incorrect method name parsed from transaction data #27363 Sep 24, 2024
@matthewwalsh0 matthewwalsh0 changed the title fix (cherry-pick): incorrect method name parsed from transaction data #27363 fix (cherry-pick): incorrect method name parsed from transaction data (#27363) Sep 24, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [816afb5]
Page Load Metrics (1757 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16302239176014771
domContentLoaded15842150172513766
load16312243175714770
domInteractive157737136

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.15%. Comparing base (439f7d6) to head (816afb5).
Report is 23 commits behind head on Version-v12.3.0.

Files with missing lines Patch % Lines
ui/selectors/selectors.js 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27379      +/-   ##
===================================================
- Coverage            70.24%   70.15%   -0.09%     
===================================================
  Files                 1426     1431       +5     
  Lines                50239    50442     +203     
  Branches             13954    13997      +43     
===================================================
+ Hits                 35289    35384      +95     
- Misses               14950    15058     +108

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm danjm merged commit 1c3f435 into Version-v12.3.0 Sep 25, 2024
79 of 80 checks passed
@danjm danjm deleted the fix/cherry-pick-27120-incorrect-parsed-method branch September 25, 2024 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Sep 25, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.3.0 on PR, as PR was cherry-picked in branch 12.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

Assignees
No one assigned
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewwalsh0 @metamaskbot @danjm